ijuma commented on a change in pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#discussion_r571853293
##########
File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala
##########
@@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(
failExpiredRequests(now)
unsentRequests.clean()
} catch {
+ case _: DisconnectException if isShutdownInitiated =>
+ // DisconnectException is caused by NetworkClient#ensureActive
+ // this thread is closing so this error is acceptable
Review comment:
I am not sure about this. We would ideally drain the existing requests
(up to a timeout), not accept new ones and then close the network client. This
change seems like it would hide the problem, but not necessarily fix it. Let's
see what @dajac and/or @hachikuji say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
