jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r572370494
##########
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##########
@@ -216,10 +217,10 @@ class ReplicaFetcherThread(name: String,
try {
val clientResponse = leaderEndpoint.sendRequest(fetchRequest)
val fetchResponse =
clientResponse.responseBody.asInstanceOf[FetchResponse[Records]]
- if (!fetchSessionHandler.handleResponse(fetchResponse)) {
+ if (!fetchSessionHandler.handleResponse(fetchResponse,
fetchRequest.latestAllowedVersion())) {
Review comment:
Good point, it should probably be along the lines of `if
(fetchRequestVersion >= 13 && !fetchData.canUseTopicIds) 12 else
fetchRequestVersion` to match how it is sent below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
