chia7712 commented on a change in pull request #10083:
URL: https://github.com/apache/kafka/pull/10083#discussion_r572542393
##########
File path:
clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##########
@@ -310,9 +310,6 @@ public void testMultipleIPsWithUseAll() throws
UnknownHostException {
connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps,
ClientDnsLookup.USE_ALL_DNS_IPS);
InetAddress addr2 = connectionStates.currentAddress(nodeId1);
Review comment:
Relying on "specify" number of IPs is still not stable for this tests
(for example, the number of resolved IPs becomes 1). It seems to me this test
should check whether the number used addresses (after building many
connections) is equal to number of resolved addresses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
