jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r573046669
##########
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##########
@@ -216,10 +217,10 @@ class ReplicaFetcherThread(name: String,
try {
val clientResponse = leaderEndpoint.sendRequest(fetchRequest)
val fetchResponse =
clientResponse.responseBody.asInstanceOf[FetchResponse[Records]]
- if (!fetchSessionHandler.handleResponse(fetchResponse)) {
+ if (!fetchSessionHandler.handleResponse(fetchResponse,
fetchRequest.latestAllowedVersion())) {
Review comment:
I just realized that fetchRequest.latestAllowedVersion is the version we
use to build the request (latest and earliest are the same.) But this is a bit
confusing, so I'll probably just use the logic mentioned above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
