cmccabe commented on a change in pull request #10084: URL: https://github.com/apache/kafka/pull/10084#discussion_r573229531
########## File path: core/src/main/scala/kafka/server/KafkaApis.scala ########## @@ -217,6 +217,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.ENVELOPE => handleEnvelope(request) case ApiKeys.DESCRIBE_CLUSTER => handleDescribeCluster(request) case ApiKeys.DESCRIBE_PRODUCERS => handleDescribeProducersRequest(request) + case ApiKeys.UNREGISTER_BROKER => maybeForwardToController(request, handleUnregisterBrokerRequest) Review comment: The comment is not invalid. It just doesn't apply to UNREGISTER_BROKER. It does apply to VOTE, BEGIN_QUORUM_EPOCH, etc. etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org