cmccabe commented on a change in pull request #10094: URL: https://github.com/apache/kafka/pull/10094#discussion_r574082124
########## File path: shell/src/main/java/org/apache/kafka/shell/MetadataShell.java ########## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.shell; + +import kafka.raft.KafkaRaftManager; +import kafka.server.KafkaConfig$; +import kafka.server.KafkaConfig; +import kafka.server.MetaProperties; +import kafka.server.Server; +import kafka.tools.TerseFailure; +import net.sourceforge.argparse4j.ArgumentParsers; +import net.sourceforge.argparse4j.inf.ArgumentParser; +import net.sourceforge.argparse4j.inf.Namespace; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.utils.Exit; +import org.apache.kafka.common.utils.Time; +import org.apache.kafka.common.utils.Utils; +import org.apache.kafka.metadata.ApiMessageAndVersion; +import org.apache.kafka.raft.RaftConfig; +import org.apache.kafka.raft.metadata.MetadataRecordSerde; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import scala.compat.java8.OptionConverters; + +import java.io.BufferedWriter; +import java.io.File; +import java.io.OutputStreamWriter; +import java.io.PrintWriter; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; +import java.util.Optional; +import java.util.Properties; + + +/** + * The Kafka metadata tool. + */ +public final class MetadataShell { + private static final Logger log = LoggerFactory.getLogger(MetadataShell.class); + + public static class Builder { + private String controllers; + private String configPath; + private File tempDir; + private String snapshotPath; + + public Builder setControllers(String controllers) { + this.controllers = controllers; + return this; + } + + public Builder setConfigPath(String configPath) { + this.configPath = configPath; + return this; + } + + public Builder setSnapshotPath(String snapshotPath) { + this.snapshotPath = snapshotPath; + return this; + } + + public Builder setTempDir(File tempDir) { + this.tempDir = tempDir; + return this; + } + + public MetadataShell build() throws Exception { + if (snapshotPath != null) { + if (controllers != null) { + throw new RuntimeException("If you specify a snapshot path, you " + Review comment: Yes, we eventually want snapshots in connected mode. However, it's up to the RaftClient to handle snapshots (or will be) so there won't be much to do in metadata shell. We wouldn't use the SnapshotReader class for that since that class is actually oriented to reading snapshots from disk directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
