jsancio commented on a change in pull request #10138:
URL: https://github.com/apache/kafka/pull/10138#discussion_r577972986
##########
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##########
@@ -106,7 +106,8 @@ public void testFetchRequestWithLargerLastFetchedEpoch()
throws Exception {
OffsetAndEpoch oldestSnapshotId = new OffsetAndEpoch(3, 2);
RaftClientTestContext context = new
RaftClientTestContext.Builder(localId, voters)
- .appendToLog(oldestSnapshotId.offset, oldestSnapshotId.epoch,
Arrays.asList("a", "b", "c"))
+ .appendToLog(oldestSnapshotId.epoch, Arrays.asList("a", "b", "c"))
+ .appendToLog(oldestSnapshotId.epoch, Arrays.asList("a", "b", "c"))
Review comment:
Yeah. The tests are getting hard to follow and write. When we have
finish some of the more important tasks, I want to revisit
`RaftClientTestContext` API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
