cmccabe commented on a change in pull request #10105:
URL: https://github.com/apache/kafka/pull/10105#discussion_r580483780
##########
File path: tests/kafkatest/services/console_consumer.py
##########
@@ -151,7 +151,10 @@ def prop_file(self, node):
def start_cmd(self, node):
"""Return the start command appropriate for the given node."""
args = self.args.copy()
- args['zk_connect'] = self.kafka.zk_connect_setting()
+ if self.new_consumer:
+ args['broker_list'] =
self.kafka.bootstrap_servers(self.security_config.security_protocol)
+ else:
+ args['zk_connect'] = self.kafka.zk_connect_setting()
Review comment:
This is a slight behavior change for the old consumer, right?
Previously we set both `broker_list` and `zk_connect`, but now we set only
`zk_connect`. Can we keep setting both for now? (I agree we should skip setting
zk_connect for the new consumer)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
