cmccabe commented on a change in pull request #9990:
URL: https://github.com/apache/kafka/pull/9990#discussion_r581289243
##########
File path: core/src/main/scala/kafka/server/ConfigHelper.scala
##########
@@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
def createResponseConfig(configs: Map[String, Any],
createConfigEntry: (String, Any) =>
DescribeConfigsResponseData.DescribeConfigsResourceResult):
DescribeConfigsResponseData.DescribeConfigsResult = {
- val filteredConfigPairs = if (resource.configurationKeys == null)
+ val filteredConfigPairs = if (resource.configurationKeys == null ||
resource.configurationKeys.isEmpty)
Review comment:
Hmm... this change doesn't seem correct. null does not mean the same
thing as empty.
This is how `ConfigurationKeys` is described in the schema:
```
{ "name": "ConfigurationKeys", "type": "[]string", "versions": "0+",
"nullableVersions": "0+",
"about": "The configuration keys to list, or null to list all
configuration keys." }
```
It doesn't say "null or empty to list all configuration keys." Just null.
Also, I looked at the code from the 2.7 release and it does not treat empty the
same as null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
