cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r582255514
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,
requestThrottleMs => createResponseCallback(requestThrottleMs))
}
+ def handleDeleteTopics(request: RequestChannel.Request): Unit = {
+ if (!config.deleteTopicEnable) {
+ if (request.context.apiVersion() < 3) {
+ throw new InvalidRequestException("Topic deletion is disabled.")
+ } else {
+ throw new TopicDeletionDisabledException()
+ }
+ }
+ val deleteTopicsRequest = request.body[DeleteTopicsRequest]
+ val nameToId = new mutable.HashMap[String, Uuid]
+ deleteTopicsRequest.data().topicNames().iterator().asScala.foreach {
+ name => nameToId.put(name, Uuid.ZERO_UUID)
+ }
+ deleteTopicsRequest.data().topics().iterator().asScala.foreach {
+ nameAndId => nameToId.put(nameAndId.name(), nameAndId.topicId())
+ }
+ val (describable, deletable) = {
+ if (authHelper.authorize(request.context, DELETE, CLUSTER,
CLUSTER_NAME)) {
+ (nameToId.keySet, nameToId.keySet)
+ } else {
+ val authorizedDescribeTopics: Set[String] =
authHelper.filterByAuthorized(
Review comment:
thanks, this is a good point. I fixed the code to accept only topic
IDs. I also found a few more bugs, and added a unit test for the deletion code
in controller apis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
