jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r582402100
##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int,
transactionMetadata.addAbortedTransactions(abortedTransactions)
val retainDeletesAndTxnMarkers = currentSegment.lastModified >
deleteHorizonMs
- info(s"Cleaning $currentSegment in log ${log.name} into
${cleaned.baseOffset} " +
+ info(s"Cleaning $currentSegment in log ${log.name} into
${currentSegment.baseOffset} " +
Review comment:
Hmmm I think I didn't really understand this log at first. It does make
sense to move it to when we know what the new segment is. I think the issue I
had was what to do with `retainDeletesAndTxnMarkers`. Maybe it makes sense to
have a log saying the current segment and the deletion info and a second log to
say what the new segment's baseOffset is later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
