dengziming commented on a change in pull request #10021:
URL: https://github.com/apache/kafka/pull/10021#discussion_r582479381
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##########
@@ -92,4 +100,22 @@ public static Path createTempFile(Path logDir,
OffsetAndEpoch snapshotId) throws
return Optional.of(new SnapshotPath(path, new
OffsetAndEpoch(endOffset, epoch), partial));
}
+
+ /**
+ * Delete this snapshot from the filesystem.
+ */
+ public static CompletableFuture<Boolean> deleteSnapshotIfExists(Path
logDir, OffsetAndEpoch snapshotId) throws IOException {
+ Path path = snapshotPath(logDir, snapshotId);
+ Path destination = Snapshots.deleteRename(path, snapshotId);
+ Utils.atomicMoveWithFallback(path, destination);
+
+ return CompletableFuture.supplyAsync(() -> {
Review comment:
If the file is deleted while Kafka is still reading the file, won't the
reading fail since we have already renamed the log file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
