hachikuji commented on a change in pull request #9958:
URL: https://github.com/apache/kafka/pull/9958#discussion_r583066513



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala
##########
@@ -430,7 +429,7 @@ private[group] class GroupMetadata(val groupId: String, 
initialState: GroupState
   private def candidateProtocols: Set[String] = {
     // get the set of protocols that are commonly supported by all members
     val numMembers = members.size
-    supportedProtocols.filter(_._2 == numMembers).map(_._1).toSet
+    supportedProtocols.filter(_._2 == numMembers).keys.toSet

Review comment:
       I tried this, but I think we still need the `toSet` because we are 
converting to the immutable `Set` type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to