rhauch commented on a change in pull request #10016:
URL: https://github.com/apache/kafka/pull/10016#discussion_r583796206
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -259,6 +267,16 @@ public void execute() {
}
}
+ private void closeProducer(Duration duration) {
+ if (producer != null) {
+ try {
+ producer.close(duration);
+ } catch (Throwable t) {
Review comment:
> Right now there aren't any code paths that lead to the worker's
executor being shut down.
Hmm, that seems to have been done a long time ago. I wonder if that was an
oversight, or whether that was intentional since in Connect the
`Worker::stop()` is called when the herder is stopped, which only happens (in
Connect) when the shutdown hook is called -- at which point the JVM is
terminating anyway. Luckily MM2 works the same way.
But in our test cases that use `EmbeddedConnectCluster`, those tests are not
cleaning up all resources of the Worker (and thus Herder) -- we might have
threads that still keep running. Seems like we should address that in a
different issue. I'll log something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
