chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584141982
##########
File path: build.gradle
##########
@@ -1401,33 +1416,35 @@ project(':streams') {
ext.buildStreamsVersionFileName = "kafka-streams-version.properties"
dependencies {
- compile project(':clients')
+ api project(':clients')
// this dependency should be removed after we unify data API
- compile(project(':connect:json')) {
+ implementation(project(':connect:json')) {
Review comment:
ditto
##########
File path: build.gradle
##########
@@ -1104,33 +1127,24 @@ project(':generator') {
project(':clients') {
archivesBaseName = "kafka-clients"
- configurations {
- jacksonDatabindConfig
- }
-
- // add jacksonDatabindConfig as provided scope config with high priority
(1000)
- conf2ScopeMappings.addMapping(1000, configurations.jacksonDatabindConfig,
"provided")
-
dependencies {
- compile libs.zstd
- compile libs.lz4
- compile libs.snappy
- compile libs.slf4jApi
+ implementation libs.zstd
Review comment:
How about exposing those compression libraries for compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
