tombentley commented on a change in pull request #10193:
URL: https://github.com/apache/kafka/pull/10193#discussion_r584648224
##########
File path:
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java
##########
@@ -320,7 +320,7 @@ public Long validate(Object item) {
if (item instanceof Long)
return (Long) item;
else
- throw new SchemaException(item + " is not a Long.");
+ throw new SchemaException(item + " is not an unsigned
integer.");
Review comment:
Though now I look at the message for `UINT16` I see it would be
consistent with that. Still I think because there are two types involved here,
the Java type and the network type, including both is clearest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]