spena commented on a change in pull request #10211:
URL: https://github.com/apache/kafka/pull/10211#discussion_r586605597
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -1136,6 +1144,22 @@ public boolean commitNeeded() {
}
}
+ @Override
+ public Map<TopicPartition, Long> getCommittedOffsets() {
+ return committedOffsets;
+ }
+
+ @Override
+ public Map<TopicPartition, Long> getHighWaterMark() {
+ highWatermark.putAll(recordCollector.offsets());
+ return highWatermark;
Review comment:
Seems the `highWatermark` is not used anywhere. Why not returning
`recordCollector.offsets()` only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
