[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

[GitBox]

mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586711923



##########
File path: build.gradle
##########
@@ -974,8 +974,8 @@ project(':core') {
     from(project(':streams:streams-scala').configurations.runtime) { 
into("libs/") }
     from(project(':streams:test-utils').jar) { into("libs/") }
     from(project(':streams:test-utils').configurations.runtime) { 
into("libs/") }
-    from(project(':streams:examples').jar) { into("libs/") }
-    from(project(':streams:examples').configurations.runtime) { into("libs/") }
+    from(project(':streams-examples').jar) { into("libs/") }
+    from(project(':streams-examples').configurations.runtime) { into("libs/") }

Review comment:
       We move the sub-module `stream/examples` into it's own module 
`streams-examples`. I would be weird to only name it `examples` as there is not 
parent `streams` reference any longer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org