hachikuji commented on a change in pull request #10256:
URL: https://github.com/apache/kafka/pull/10256#discussion_r587803031
##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -220,25 +220,14 @@ class KafkaRaftManager[T](
}
private def buildMetadataLog(): KafkaMetadataLog = {
- val defaultProps = LogConfig.extractLogConfigMap(config)
Review comment:
It seemed best for now to not allow overrides since this is a new usage
of `Log` and we haven't had time to understand the impact of all of the
configurations for this usage. Most of them are probably safe, but others do
not even make sense (e.g. the retention settings). Let me open a JIRA so that
we can consider which configs we want to expose for the metadata log and how we
want to expose them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
