chia7712 commented on a change in pull request #10269:
URL: https://github.com/apache/kafka/pull/10269#discussion_r588049874
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -294,14 +294,24 @@ trait FetchContext extends Logging {
*/
def updateAndGenerateResponseData(updates: FetchSession.RESP_MAP):
FetchResponse
- def partitionsToLogString(partitions: util.Collection[TopicPartition]):
String =
- FetchSession.partitionsToLogString(partitions, isTraceEnabled)
+ def partitionsToLogString(topics: FetchSession.RESP_MAP): String = {
Review comment:
this method is used to log (DEBUG level) so it should be fine to iterate
through whole collection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
