[GitHub] [kafka] jsancio commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

[GitBox]

jsancio commented on a change in pull request #10021:
URL: https://github.com/apache/kafka/pull/10021#discussion_r591079811



##########
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##########
@@ -16,16 +16,21 @@
  */
 package org.apache.kafka.snapshot;
 
+import org.apache.kafka.raft.OffsetAndEpoch;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.text.NumberFormat;
 import java.util.Optional;
-import org.apache.kafka.raft.OffsetAndEpoch;
 
 public final class Snapshots {
-    private static final String SUFFIX =  ".checkpoint";
+    private static final Logger log = LoggerFactory.getLogger(Snapshots.class);
+    private static final String SUFFIX = ".checkpoint";
     private static final String PARTIAL_SUFFIX = String.format("%s.part", 
SUFFIX);
+    private static final String DELETE_SUFFIX = ".deleted";

Review comment:
       @dengziming Sorry that I didn't notice this earlier. Why don't we make 
the `DELETE_SUFIX` similar to the `PARTIAL_SUFFIX`? E.g. `public static final 
String DELETE_SUFFIX = String.format("%s.deleted", SUFFIX);`
   
   This will give us the follow filename suffixes:
   
   1. Immutable snapshots - `.checkpoint`
   2. Partial snapshots - `.checkpoint.part`
   3. Deleted snapshots - `checkpoint.deleted`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org