rondagostino commented on a change in pull request #10292:
URL: https://github.com/apache/kafka/pull/10292#discussion_r592639264
##########
File path: tests/kafkatest/tests/client/client_compatibility_features_test.py
##########
@@ -130,4 +134,7 @@ def run_compatibility_test(self, broker_version,
metadata_quorum=quorum.zk):
self.kafka.set_version(KafkaVersion(broker_version))
self.kafka.start()
features = get_broker_features(broker_version)
+ if not self.zk:
+ # this is supported by zkBroker currently
+ features["describe-acls-supported"] = False
Review comment:
Nice -- better than disabling the test for Raft-based quorums. Perhaps
add to the comment to indicate that this check/disabling is only necessary due
to the fact that we are in early access mode with KIP-500 and we should remove
the special casing when that his fully implemented? Aside from that, LGTM --
thank you for the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
