jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r594552602
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -308,27 +308,29 @@ class Partition(val topicPartition: TopicPartition,
s"different from the requested log dir $logDir")
false
case None =>
- createLogIfNotExists(isNew = false, isFutureReplica = true,
highWatermarkCheckpoints)
+ // not sure if topic ID should be none here, but not sure if we
have access in ReplicaManager where this is called.
Review comment:
TODO: remove this when we decide if we want to pass in None or a topicID
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
