jsancio commented on pull request #10324: URL: https://github.com/apache/kafka/pull/10324#issuecomment-800745760
Test result after fixing the benchmark tests: ``` Benchmark (mapType) (size) Mode Cnt Score Error Units TimelineHashMapBenchmark.testAddEntries HASH_MAP 1000000 avgt 10 184.183 ± 12.318 ms/op TimelineHashMapBenchmark.testAddEntries SCALA_HASH_MAP 1000000 avgt 10 350.935 ± 4.801 ms/op TimelineHashMapBenchmark.testAddEntries TIMELINE_MAP 1000000 avgt 10 340.839 ± 15.397 ms/op TimelineHashMapBenchmark.testAddEntries TIMELINE_SNAPSHOT_MAP 1000000 avgt 10 332.535 ± 36.350 ms/op TimelineHashMapBenchmark.testGetEntries HASH_MAP 1000000 avgt 10 37.772 ± 4.717 ms/op TimelineHashMapBenchmark.testGetEntries SCALA_HASH_MAP 1000000 avgt 10 248.350 ± 4.445 ms/op TimelineHashMapBenchmark.testGetEntries TIMELINE_MAP 1000000 avgt 10 83.487 ± 6.952 ms/op TimelineHashMapBenchmark.testIterateEntries HASH_MAP 1000000 avgt 10 42.743 ± 1.184 ms/op TimelineHashMapBenchmark.testIterateEntries SCALA_HASH_MAP 1000000 avgt 10 36.030 ± 0.937 ms/op TimelineHashMapBenchmark.testIterateEntries TIMELINE_MAP 1000000 avgt 10 54.760 ± 2.866 ms/op TimelineHashMapBenchmark.testRemoveEntries HASH_MAP 1000000 avgt 10 26.246 ± 1.141 ms/op TimelineHashMapBenchmark.testRemoveEntries SCALA_HASH_MAP 1000000 avgt 10 430.861 ± 13.864 ms/op TimelineHashMapBenchmark.testRemoveEntries TIMELINE_MAP 1000000 avgt 10 79.832 ± 12.833 ms/op TimelineHashMapBenchmark.testRemoveEntries TIMELINE_SNAPSHOT_MAP 1000000 avgt 10 185.170 ± 13.464 ms/op TimelineHashMapBenchmark.testUpdateEntries HASH_MAP 1000000 avgt 10 84.963 ± 10.411 ms/op TimelineHashMapBenchmark.testUpdateEntries SCALA_HASH_MAP 1000000 avgt 10 426.490 ± 6.468 ms/op TimelineHashMapBenchmark.testUpdateEntries TIMELINE_MAP 1000000 avgt 10 160.341 ± 13.799 ms/op TimelineHashMapBenchmark.testUpdateEntries TIMELINE_SNAPSHOT_MAP 1000000 avgt 10 300.875 ± 35.965 ms/op JMH benchmarks done ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org