chia7712 commented on a change in pull request #10334:
URL: https://github.com/apache/kafka/pull/10334#discussion_r596496496
##########
File path: metadata/src/main/java/org/apache/kafka/timeline/BaseHashTable.java
##########
@@ -56,12 +61,27 @@
this.elements = new Object[expectedSizeToCapacity(expectedSize)];
}
+ /**
+ * Calculate the capacity we should provision, given the expected size.
+ *
+ * Our capacity must always be a power of 2, and never less than 2.
+ */
static int expectedSizeToCapacity(int expectedSize) {
- if (expectedSize <= 1) {
- return 2;
+ if (expectedSize >= MAX_CAPACITY / 2) {
+ return MAX_CAPACITY;
+ }
+ return Math.max(MIN_CAPACITY, roundUpToPowerOfTwo(expectedSize * 2));
+ }
+
+ private static int roundUpToPowerOfTwo(int i) {
+ if (i <= 0) {
+ return 0;
+ } else if (i > MAX_SIGNED_POWER_OF_TWO) {
Review comment:
Sorry for my unclear comment.
I assumed that all negative numbers are acceptable for
`expectedSizeToCapacity` because of test case `assertEquals(2,
BaseHashTable.expectedSizeToCapacity(-123));`. However, some magic numbers (for
example, `-1610612735`) can produce `ArithmeticException`.
At any rate, above case are nonexistent in latest commit now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
