ableegoldman commented on a change in pull request #10342:
URL: https://github.com/apache/kafka/pull/10342#discussion_r599077785
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -410,8 +374,8 @@ public void close() {
}
// all threads should be stopped and cleaned up by now, so none
should remain holding a lock
- if (locks.isEmpty()) {
- log.error("Some task directories still locked while closing
state, this indicates unclean shutdown: {}", locks);
+ if (lockedTasksToStreamThreadOwner.isEmpty()) {
Review comment:
Ahhh yeah it should. I kept wondering why I was seeing this sometimes in
the soak or various unit tests, and just assumed it was because of an unclean
shutdown 🤦♀️. Thanks for catching this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
