chia7712 commented on pull request #9858: URL: https://github.com/apache/kafka/pull/9858#issuecomment-804586361
@mjsax Sorry for lazy response. I did not notice your feedback until @vvcephei touch this PR :( > This PR is huge and contains a lot of reformatting. Is this required? Very tedious to review. Why are there so many Java class changes -- this PR does not migrate Java tests to JUnit5? Could this PR be split into multiple smaller ones to make it easier to review? We are migrate code to Junit 5 by module in order to avoid huge patch (although this patch is still big ...). The root cause of making this tedious patch is that `stream-scale` depends on `stream` module (`EmbeddedKafkaCluster`, to be exact). Unfortunately, the Junit APIs used by `EmbeddedKafkaCluster` belong to Junit 4 and those APIs are not compatible to Junit 5. That is why this patch has to reformat a lot of java code of streams module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
