ijuma commented on a change in pull request #10386:
URL: https://github.com/apache/kafka/pull/10386#discussion_r600409509
##########
File path: build.gradle
##########
@@ -167,6 +167,10 @@ if (file('.git').exists()) {
}
}
+// Apply 'java' to the root project so that the root-level task
'aggregatedJavadoc' can depend on compileJava
+// Weirdly, this seems to be required for some people, but not others. It
doesn't seem to be harmful to add it
+// here, in any case.
+apply plugin: 'java'
Review comment:
I think you can move this to `allprojects` (so it can be near other
similar `apply` calls) and remove `apply plugin: 'java'` from `subprojects`
(not 100% sure about the latter since it depends on the evaluation order). I
think we can also remove the comment since we now know that the `rat` plugin
was doing this all along anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
