[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

[GitBox]

dhruvilshah3 commented on a change in pull request #10388:
URL: https://github.com/apache/kafka/pull/10388#discussion_r601867672



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -700,11 +700,13 @@ class Log(@volatile private var _dir: File,
           case _: NoSuchFileException =>
             error(s"Could not find offset index file corresponding to log file 
${segment.log.file.getAbsolutePath}, " +
               "recovering segment and rebuilding index files...")
-            recoverSegment(segment)
+            if (segment.validateSegmentAndRebuildIndices() > 0)

Review comment:
       Makes sense. I reworked the logic to handle unflushed files the right 
way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org