rhauch commented on a change in pull request #10396:
URL: https://github.com/apache/kafka/pull/10396#discussion_r603575020
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
##########
@@ -363,10 +363,16 @@ public void tick() {
if (checkForKeyRotation(now)) {
log.debug("Distributing new session key");
keyExpiration = Long.MAX_VALUE;
- configBackingStore.putSessionKey(new SessionKey(
- keyGenerator.generateKey(),
- now
- ));
+ try {
+ configBackingStore.putSessionKey(new SessionKey(
+ keyGenerator.generateKey(),
+ now
+ ));
+ } catch (Exception e) {
+ log.warn("Failed to write new session key to config topic;
forcing a read to the end of the config topic before possibly retrying");
Review comment:
Is this worthy of a warning message rather than an info-level message,
especially if we think the herder can automatically recover from typical causes
of this (e.g., transient network issues, transient broker issues, etc.)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
