[GitHub] [kafka] dajac commented on a change in pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

[GitBox]

dajac commented on a change in pull request #10446:
URL: https://github.com/apache/kafka/pull/10446#discussion_r604843035



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java
##########
@@ -188,6 +188,7 @@ public int hashCode() {
         result = prime * result + (isReadOnly ? 1 : 0);
         result = prime * result + source.hashCode();
         result = prime * result + synonyms.hashCode();
+        result = prime * result + type.hashCode();

Review comment:
       `documentation` is not here nor in `toString` neither.  Should we add it 
as well? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org