showuon commented on a change in pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#discussion_r606757807
##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -1775,29 +1429,26 @@ object ReassignPartitionsCommand extends Logging {
sealed class ReassignPartitionsCommandOptions(args: Array[String]) extends
CommandDefaultOptions(args) {
// Actions
- val verifyOpt = parser.accepts("verify", "Verify if the reassignment
completed as specified by the --reassignment-json-file option. If there is a
throttle engaged for the replicas specified, and the rebalance has completed,
the throttle will be removed")
+ val verifyOpt = parser.accepts("verify", "Verify if the reassignment
completed as specified by the " +
+ "--reassignment-json-file option. If there is a throttle engaged for the
replicas specified, and the rebalance has completed, the throttle will be
removed")
val generateOpt = parser.accepts("generate", "Generate a candidate
partition reassignment configuration." +
" Note that this only generates a candidate assignment, it does not
execute it.")
val executeOpt = parser.accepts("execute", "Kick off the reassignment as
specified by the --reassignment-json-file option.")
val cancelOpt = parser.accepts("cancel", "Cancel an active reassignment.")
val listOpt = parser.accepts("list", "List all active partition
reassignments.")
// Arguments
- val bootstrapServerOpt = parser.accepts("bootstrap-server", "the server(s)
to use for bootstrapping. REQUIRED if " +
- "an absolute path of the log directory is specified for
any replica in the reassignment json file, " +
- "or if --zookeeper is not given.")
+ val bootstrapServerOpt = parser.accepts("bootstrap-server", "REQUIRED: the
server(s) to use for bootstrapping.")
.withRequiredArg
.describedAs("Server(s) to use for bootstrapping")
.ofType(classOf[String])
+ .required()
Review comment:
Make `bootstrapServerOpt` as required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
