ijuma commented on a change in pull request #10445:
URL: https://github.com/apache/kafka/pull/10445#discussion_r608208702
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java
##########
@@ -107,7 +108,7 @@ Long checksumOrNull() {
RecordMetadata value() {
if (nextRecordMetadata != null)
return nextRecordMetadata.value();
- return new RecordMetadata(result.topicPartition(),
this.result.baseOffset(), this.relativeOffset,
+ return new RecordMetadata(result.topicPartition(),
this.result.baseOffset(), this.batchIndex,
Review comment:
The argument in `RecordMetadata` is still `relativeOffset`. Is that
intended? If so, it would be good to add a comment as it's a bit confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
