g1geordie commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-815594893


   @bbejeck 
   Thanks for your response !!
   
   I see the compatibility claim in NamedInternal.
   ```
   String orElseGenerateWithPrefix(final InternalNameProvider provider, final 
String prefix) {
           // We actually do not need to generate processor names for operation 
if a name is specified.
           // But before returning, we still need to burn index for the 
operation to keep topology backward compatibility.
           ...
   }
   ```
   The index is not correct  in 
SuppressTopologyTest.shouldApplyNameToSuppressionNode.
          
   ```
   without  `.suppress(... .withName("asdf"))` name option.
        
   Topologies:
      Sub-topology: 0
       Source: KSTREAM-SOURCE-0000000000 (topics: [input])
         --> KSTREAM-AGGREGATE-0000000002
       Processor: KSTREAM-AGGREGATE-0000000002 (stores: 
[KSTREAM-AGGREGATE-STATE-STORE-0000000001])
         --> KTABLE-SUPPRESS-0000000003
         <-- KSTREAM-SOURCE-0000000000
       Processor: KTABLE-SUPPRESS-0000000003 (stores: 
[KTABLE-SUPPRESS-STATE-STORE-0000000004])
         --> KTABLE-TOSTREAM-0000000005
         <-- KSTREAM-AGGREGATE-0000000002
       Processor: KTABLE-TOSTREAM-0000000005 (stores: [])
         --> KSTREAM-SINK-0000000006
         <-- KTABLE-SUPPRESS-0000000003
       Sink: KSTREAM-SINK-0000000006 (topic: output)
         <-- KTABLE-TOSTREAM-0000000005
   ```
   So I change expected index to below .
   ```
   Topologies:
      Sub-topology: 0
       Source: KSTREAM-SOURCE-0000000000 (topics: [input])
         --> KSTREAM-AGGREGATE-0000000002
       Processor: KSTREAM-AGGREGATE-0000000002 (stores: 
[KSTREAM-AGGREGATE-STATE-STORE-0000000001])
         --> asdf
         <-- KSTREAM-SOURCE-0000000000
       Processor: asdf (stores: [asdf-store])
         --> KTABLE-TOSTREAM-0000000005
         <-- KSTREAM-AGGREGATE-0000000002
       Processor: KTABLE-TOSTREAM-0000000005 (stores: [])
         --> KSTREAM-SINK-0000000006
         <-- asdf
       Sink: KSTREAM-SINK-0000000006 (topic: output)
         <-- KTABLE-TOSTREAM-0000000005  
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to