C0urante commented on a change in pull request #10503:
URL: https://github.com/apache/kafka/pull/10503#discussion_r610316462
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
##########
@@ -185,8 +185,12 @@ private void doRun() throws InterruptedException {
execute();
} catch (Throwable t) {
- log.error("{} Task threw an uncaught and unrecoverable exception.
Task is being killed and will not recover until manually restarted", this, t);
- throw t;
+ if (!stopping && !cancelled) {
Review comment:
I was thinking we could log different messages based on whether only
`stopping` or both `stopping` and `cancelled` were true. If `cancelled` is
true, we should make sure to let people know that there might be a newer
instance of this task already running, and that the log message isn't
indicative that that newer instance has failed. If only `stopping` is true,
then the existing log message should suffice. Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
