tombentley commented on a change in pull request #10499:
URL: https://github.com/apache/kafka/pull/10499#discussion_r610704990
##########
File path: tests/docker/ducker-ak
##########
@@ -217,6 +217,8 @@ ask_yes_no() {
# $1: The name of the image to build.
ducker_build() {
local image_name="${1}"
+ local what="${2}"
+ [[ -n "${what}" ]] || what="${image_name}"
Review comment:
The new argument isn't mentioned in the PR description and isn't used in
the rest of the patch.
##########
File path: tests/docker/ducker-ak
##########
@@ -311,15 +313,16 @@ use only ${num_nodes}."
ducker_build "${image_name}"
- docker inspect --format='{{.Config.Labels}}' --type=image "${image_name}"
| grep -q 'ducker.type'
- local docker_status=${PIPESTATUS[0]}
- local grep_status=${PIPESTATUS[1]}
+ docker inspect --format='{{.Config.Labels}}' --type=image "${image_name}"
| grep -q 'ducker.creator'
Review comment:
Why change the argument to grep?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
