hachikuji commented on a change in pull request #10510:
URL: https://github.com/apache/kafka/pull/10510#discussion_r610835639



##########
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##########
@@ -137,6 +137,65 @@ public void 
testRejectVotesFromSameEpochAfterResigningCandidacy() throws Excepti
         context.assertSentVoteResponse(Errors.NONE, epoch, 
OptionalInt.empty(), false);
     }
 
+    @Test
+    public void testGrantVotesFromHigherEpochAfterResigningLeadership() throws 
Exception {

Review comment:
       A couple other potentially interesting test cases:
   
   1. After starting in a resigned state, verify that the node will become a 
candidate after the election timer expires.
   2. Verify that we can vote for new candidates when in the resigned state 
after shutting down.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to