jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r610952440
##########
File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java
##########
@@ -418,48 +414,49 @@ public RawSnapshotWriter createSnapshot(OffsetAndEpoch
snapshotId) {
public void onSnapshotFrozen(OffsetAndEpoch snapshotId) {}
@Override
- public boolean deleteBeforeSnapshot(OffsetAndEpoch logStartSnapshotId) {
- if (logStartOffset() > logStartSnapshotId.offset ||
- highWatermark.offset < logStartSnapshotId.offset) {
+ public boolean deleteBeforeSnapshot(OffsetAndEpoch snapshotId) {
+ if (logStartOffset() > snapshotId.offset ||
+ highWatermark.offset < snapshotId.offset) {
throw new OffsetOutOfRangeException(
String.format(
"New log start (%s) is less than start offset (%s) or is
greater than the high watermark (%s)",
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
