cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r613551280
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -347,21 +370,22 @@ class ControllerApis(val requestChannel: RequestChannel,
iterator.remove()
}
}
- val response = controller.createTopics(effectiveRequest).get()
- duplicateTopicNames.forEach { name =>
- response.topics().add(new CreatableTopicResult().
- setName(name).
- setErrorCode(INVALID_REQUEST.code()).
- setErrorMessage("Found multiple entries for this topic."))
- }
- topicNames.forEach { name =>
- if (!authorizedTopicNames.contains(name)) {
+ controller.createTopics(effectiveRequest).thenApply(response => {
+ duplicateTopicNames.forEach { name =>
response.topics().add(new CreatableTopicResult().
setName(name).
- setErrorCode(TOPIC_AUTHORIZATION_FAILED.code()))
+ setErrorCode(INVALID_REQUEST.code).
+ setErrorMessage("Found multiple entries for this topic."))
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
