chia7712 commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613753836
##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -280,7 +284,7 @@ object DumpLogSegments {
if (batch.magic >= RecordBatch.MAGIC_VALUE_V2) {
print(" sequence: " + record.sequence + " headerKeys: " +
record.headers.map(_.key).mkString("[", ",", "]"))
} else {
- print(s" crc: ${record.checksumOrNull} isvalid:
${record.isValid}")
+ print(s" crc: $checksum isvalid: ${record.isValid}")
Review comment:
yep, it printed the checksum twice if magic code is smaller than 2. Will
remove the duplicate print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
