[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325140#comment-17325140 ]
Jose Armando Garcia Sancio commented on KAFKA-10800: ---------------------------------------------------- Yes. Please take it. Can you also look into the following when the snapshot gets created using {{SnaphsotWriter}}: 1. Set the {{baseOffset}} to the snapshotId's {{endOffset - 1}} for every record batch. 2. Set the relative offset for every record to 0. 3. Se the epoch of every batch to the snapshotId's epoch. > Validate the snapshot id when the state machine creates a snapshot > ------------------------------------------------------------------ > > Key: KAFKA-10800 > URL: https://issues.apache.org/jira/browse/KAFKA-10800 > Project: Kafka > Issue Type: Sub-task > Components: replication > Reporter: Jose Armando Garcia Sancio > Priority: Major > > When the state machine attempts to create a snapshot writer we should > validate that the following is true: > # The end offset and epoch of the snapshot is less than the high-watermark. > # The end offset and epoch of the snapshot is valid based on the leader > epoch cache. > Note that this validation should not be performed when the raft client > creates the snapshot writer because in that case the local log is out of date > and the follower should trust the snapshot id sent by the partition leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)