[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

[GitBox]

Nathan22177 commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-824837667


   > > All of them already had the checks.
   > 
   > Sweet. I did not double check the code before.
   > 
   > Seems, `put(final Windowed<K> sessionKey,...)` and `remove(final 
Windowed<K> sessionKey)` don't check for `sessionKey.key() != null` though? Can 
we add this check?
   They do? Might be that we're talking different classes?
   
![image](https://user-images.githubusercontent.com/44339288/115721607-dfc35e00-a386-11eb-899c-19a77b6d986c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org