kowshik commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r622787996
##########
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java
##########
@@ -270,9 +247,9 @@ public String toString() {
"remoteLogSegmentId=" + remoteLogSegmentId +
", startOffset=" + startOffset +
", endOffset=" + endOffset +
- ", brokerId=" + brokerId +
+ ", brokerId=" + brokerId() +
Review comment:
Interesting, there are tons of references to `StringBuilder` in the AK
code base today: https://github.com/apache/kafka/search?p=1&q=StringBuilder.
Are you saying most of these are overkill?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
