jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r623367035
##########
File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java
##########
@@ -60,19 +61,21 @@
@Override
void close();
- class Batch<T> {
+ final class Batch<T> implements Iterable<T> {
private final long baseOffset;
private final int epoch;
+ private final long lastOffset;
private final List<T> records;
- public Batch(long baseOffset, int epoch, List<T> records) {
+ private Batch(long baseOffset, int epoch, long lastOffset, List<T>
records) {
Review comment:
Yes. I documented the static methods for creating objects of this type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
