ableegoldman commented on pull request #10597: URL: https://github.com/apache/kafka/pull/10597#issuecomment-829564963
Thanks @vitojeng -- just to clarify, I was proposing that we do throw the StreamsNotStartedException for the `#allMetadata`, `#allMetadataForStore`, and `#queryMetadataForKey` methods in addition to just `#store`. Imo if we do this for `#store`, we should do it for all of these which have similar behavior and effect -- for example at the moment, all of these invoke `validateRunningOrRebalance` and thus would all throw IllegalStateException if the Streams has not been started. It seems odd to add this exception which perfectly addresses this specific case, and then only apply it to that one method. What I was saying we should _not_ do was to throw StreamsNotStartedException for _any_ state that isn't RUNNING or REBALANCING. In other words we still only throw it for CREATED, but we throw the same exception across the board. Basically any method that currently invokes `validateRunningOrRebalancing` (which is `#store` + the ones listed above, I believe there are 5 methods in total) Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
