dengziming commented on a change in pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#discussion_r624846310



##########
File path: 
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
##########
@@ -49,7 +49,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: 
ClusterInstance) {
     val overrideHeader = 
IntegrationTestUtils.nextRequestHeader(ApiKeys.API_VERSIONS, Short.MaxValue)
     val socket = 
IntegrationTestUtils.connect(cluster.brokerSocketServers().asScala.head, 
cluster.clientListener())
     try {
-      IntegrationTestUtils.sendWithHeader(request, overrideHeader, socket)
+      val serializedBytes = Utils.toArray(

Review comment:
       Because this method is used to test the version inconsistency between 
request header and request body, but `IntegrationTestUtils.sendWithHeader` will 
inspect the version and throws `IllegalArgumentException` on inconsistency 
after this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to