guozhangwang commented on a change in pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#discussion_r625419038
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
}
@Override
- @Deprecated
public WindowStoreIterator<V> fetch(final K key,
- final long timeFrom,
- final long timeTo) {
+ final Instant timeFrom,
Review comment:
Ditto below.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
}
@Override
- @Deprecated
public WindowStoreIterator<V> fetch(final K key,
- final long timeFrom,
- final long timeTo) {
+ final Instant timeFrom,
Review comment:
Seems we are removing the `ApiUtils.validateMillisecondInstant` check
here, is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
