cadonna commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r627228005
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##########
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+ @Override
+ public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+ dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+ return this;
+ }
+
+ @Override
+ public long maxWriteBatchGroupSizeBytes() {
+ return dbOptions.maxWriteBatchGroupSizeBytes();
+ }
+
+ @Override
+ public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+ columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+ return this;
+ }
+
+ @Override
+ public Options optimizeForSmallDb(final Cache cache) {
+ return super.optimizeForSmallDb(cache);
+ }
+
+ @Override
+ public AbstractCompactionFilter<? extends AbstractSlice<?>>
compactionFilter() {
+ return columnFamilyOptions.compactionFilter();
+ }
+
+ @Override
+ public AbstractCompactionFilterFactory<? extends
AbstractCompactionFilter<?>> compactionFilterFactory() {
+ return columnFamilyOptions.compactionFilterFactory();
+ }
+
+ @Override
+ public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+ dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+ return this;
+ }
+
+ @Override
+ public int statsPersistPeriodSec() {
+ return dbOptions.statsPersistPeriodSec();
+ }
+
+ @Override
+ public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+ dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+ return this;
+ }
+
+ @Override
+ public long statsHistoryBufferSize() {
+ return dbOptions.statsHistoryBufferSize();
+ }
+
+ @Override
+ public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+ dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+ return this;
+ }
+
+ @Override
+ public boolean strictBytesPerSync() {
+ return dbOptions.strictBytesPerSync();
+ }
+
+ @Override
+ public Options setListeners(final List<AbstractEventListener> listeners) {
+ dbOptions.setListeners(listeners);
+ return this;
+ }
+
+ @Override
+ public List<AbstractEventListener> listeners() {
+ return dbOptions.listeners();
+ }
+
+ @Override
+ public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+ dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+ return this;
+ }
+
+ @Override
+ public boolean enablePipelinedWrite() {
+ return dbOptions.enablePipelinedWrite();
+ }
+
+ @Override
+ public Options setUnorderedWrite(final boolean unorderedWrite) {
+ dbOptions.setUnorderedWrite(unorderedWrite);
+ return this;
+ }
+
+ @Override
+ public boolean unorderedWrite() {
+ return dbOptions.unorderedWrite();
+ }
+
+ @Override
+ public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+ return this;
+ }
+
+ @Override
+ public boolean skipCheckingSstFileSizesOnDbOpen() {
+ return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+ }
+
+ @Override
+ public Options setWalFilter(final AbstractWalFilter walFilter) {
+ dbOptions.setWalFilter(walFilter);
Review comment:
Good catch! All those option objects are driving me crazy! 🙂
Yes, then we could log a warn and ignore the attribute or we could do
nothing since it will not change anything. Throwing an exception seems a bit
harsh to me.
Whatever, we decide I would like to have that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
