mdedetrich opened a new pull request #10648: URL: https://github.com/apache/kafka/pull/10648
This PR is continuation of https://github.com/apache/kafka/pull/9395 which has been rebased to work with the latest `trunk` of Apache. As stated in the original PR, it adds a `LegacyReplicationPolicy` for MirrorMaker2 which imitates the behavior of MirrorMaker1 (i.e. it doesn't rename the the topics apart from `heartbeat`). The behavior of this PR is exactly the same as the stated original. Here are some additional notes/changes that are different from the original PR. * An additional constructor for the `startClusters()` has been added which allows you to supply test specific MirrorMaker configs. This allows the `LegacyReplicationPolicy` tests to use as much more code from the base `MirrorConnectorsIntegrationBaseTest`, heavily reducing boilerplate when compared to the original PR * Certain methods/fields of `MirrorConnectorsIntegrationBaseTest` have been changed from `private` to `protected` so that `LegacyReplicationPolicy` specific tests can access them. @ryannedolan You reviewed the original PR and in that PR you stated that a KIP is needed since we are adding a public method to the `ReplicationPolicy` interface, is this still necessary? You also had issues with the `canTrackSource` method name, do you have a better alternative? ## Committer Checklist (excluded from commit message) * [ ] Verify design and implementation * [ ] Verify test coverage and CI build status * [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
