chia7712 commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r633090928



##########
File path: build.gradle
##########
@@ -380,6 +380,15 @@ subprojects {
     }
   }
 
+  cleanTest {
+    subprojects.each {
+      delete "${it.buildDir}/test-results/unitTest"
+      delete "${it.buildDir}/reports/tests/unitTest"
+      delete "${it.buildDir}/test-results/integrationTest"
+      delete "${it.buildDir}/reports/tests/integrationTest"
+    }
+  }
+

Review comment:
       > Is it useful for unit and integration test to use separate output 
dirs? Or should they all write to the same output dir as the tests command?
   
   We need to combine the reports if unit and integration test use the same 
output dir. Otherwise, the following command can generate only one report.
   ```./gradlew cleanTest xxx:unitTest xxx:integrationTest```
   Also, changing the output dir of unit/integration may introduce some 
compatibility issue. It seems to me removing the output dirs is simpler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to